flameshot icon indicating copy to clipboard operation
flameshot copied to clipboard

Fails when fractional scaling <> 100%

Open fzaninotto opened this issue 5 years ago • 119 comments

Ubuntu 19.04 supports fractional scaling on Wayland and Xorg. When using a factor that is not the default (like 150%, for instance on a HiDPI display), and trying to capture a screenshot with flameshot, the screen flickers an changes resolution. and flameshot can only capture a quadrant of the screen.

fzaninotto avatar Jun 21 '19 13:06 fzaninotto

please fix this - affects the core functionality of the product when using a HiDPI screen

dszryan avatar Sep 11 '19 01:09 dszryan

Any update on this? Since the demise of Shutter, Flameshot is the best tool, but without fractional scaling it is no good to me.

flantel avatar Nov 29 '19 14:11 flantel

@fzaninotto @flantel Hello, I tried to make a fix. Can you please test patched version released here as downloadable built archive with x64 executable https://github.com/Mart-Bogdan/flameshot/releases/tag/tmp-fix-scaling

Mart-Bogdan avatar Jan 02 '20 02:01 Mart-Bogdan

Hi,

No, unfortunately this does not work for me. The screen keeps flipping around between different resolutions. This is on Ubuntu 19,10/Gnome

flantel avatar Jan 02 '20 18:01 flantel

@flantel you are using 200% scaling? indeed it wasn't working on 2x only on fractional, like 1.5x New patch should work https://github.com/Mart-Bogdan/flameshot/releases/tag/tmp-fix-scaling-2 I've tested it on Gnome too.

Mart-Bogdan avatar Jan 03 '20 20:01 Mart-Bogdan

Hi @Mart-Bogdan I am using 150% on a Pixelbook, running ubuntu 19.10/Gnome/X

Result is the same - screen will flip between small and normal and continues to do so until I press escape.

flantel avatar Jan 03 '20 22:01 flantel

Same issue on Pop_OS! on both an Eve V (surface pro look-alike) and a Matebook X Pro, both at 150%.

adampiskorski avatar Feb 10 '20 06:02 adampiskorski

Same here on Pop_OS Surface Laptop 2 at 150% Impossible to take a screenshot, it just toggles constantly big/small/big/small/...

CumpsD avatar May 11 '20 18:05 CumpsD

@Mart-Bogdan Hi Bogdan, can you please confirm if your fix for fractional scaling was indeed incorporated into the main flameshot branch? Occasionally I get flameshot updates from OpenSUSE and it is breaking it, so clearly at least SUSE does not have that patch.

karolbe avatar Jun 15 '20 09:06 karolbe

@Mart-Bogdan Hi Bogdan, can you please confirm if your fix for fractional scaling was indeed incorporated into the main flameshot branch? Occasionally I get flameshot updates from OpenSUSE and it is breaking it, so clearly at least SUSE does not have that patch.

Hello, no it wasn't. there were someone who took my changes into their fork.

Likely this form merged it https://github.com/hosiet/flameshot

But I've found that my patch don't work well with dual monitor set-up. And I won't have time to take a look in the coming weeks.

Mart-Bogdan avatar Jun 15 '20 11:06 Mart-Bogdan

I have dual monitors (although with the same 4k resolution with fractional scaling) and it works perfectly. OK, I will just keep using your build. Thanks for your work!

karolbe avatar Jun 15 '20 12:06 karolbe

If they are at different horizontal level tool buttons are aligned wierdly.

On Mon, Jun 15, 2020, 15:04 Karol Bryd [email protected] wrote:

I have dual monitors (although with the same 4k resolution with fractional scaling) and it works perfectly. OK, I will just keep using your build. Thanks for your work!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lupoDharkael/flameshot/issues/564#issuecomment-644087910, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF5G7XMBKIICEMCS7HW7WLRWYE6TANCNFSM4H2RTW5A .

Mart-Bogdan avatar Jun 15 '20 14:06 Mart-Bogdan

flameshot does not work fine at scale 125% display Ubuntu 20.04 LTS The screen become flashing

SergioBurlaka avatar Jul 22 '20 09:07 SergioBurlaka

same at at scale 125% display Ubuntu 20.04 LTS

zhenglinli avatar Aug 09 '20 03:08 zhenglinli

Same here on Arch Linux w/ KDE on X11 while using version 0.8.1 Rolling back to version 0.6.0 seems to work for me

yechs avatar Sep 25 '20 12:09 yechs

Ubuntu 20.04.1 LTS here with Dual HiDPI monitors set to 150% fractional scaling.

Running the very latest Flameshot release (0.8.5) when I try to take a screenshot both my monitors flicker on and off and it becomes actually difficult to break out of.

Has there been any progress addressing this issue? Is there a beta or alpha build we could try?

I have tried this: https://github.com/Mart-Bogdan/flameshot/releases/tag/tmp-fix-scaling-2 and it doesn't work for me.

bab5470 avatar Nov 06 '20 23:11 bab5470

I'm actively working on it but it is not an easy issue to solve.

Im at a point where I can confirm the screenshot is actually taken and sized correctly, however it displays with an X offset. I haven't quite figured out why.

borgmanJeremy avatar Nov 07 '20 01:11 borgmanJeremy

Ive made some good progress on this. I can correct the offset by adding a move command here: https://github.com/flameshot-org/flameshot/blob/eef2b75bf7d02a6fbfee8c8dbc59eb35afaa4337/src/widgets/capture/capturewidget.cpp#L120

The offset for my current test is 640px. My current set setup is 2x monitors with 1920x1080 resolution and fractional scaling of 1.5.

1920 * 2monitors / 640 = 6. I don't understand why there is this factor of 6, but the fact that its a perfect divisor makes me think I am on the right track.

Edit: Okay great I figured it out....still want to understand WHY the issue occurs, but there is scare documentation on QT fractional scaling. The offset is: resolution of primary display - resolution of primary display* (1/scaling)

Edit: It also seems to only happen when the primary screen is on the left.

Edit: 2020/11/22: Still havent uncovered root cause. My next step is creating a minimal working example to post on the QT forums.

Edit: 2020/11/23: Minimal working example of bug posted here: https://forum.qt.io/topic/121111/position-of-widget-with-fractional-scaling

borgmanJeremy avatar Nov 15 '20 02:11 borgmanJeremy

flameshot does not work fine at scale 125% display Ubuntu 20.04 LTS The screen become flashing

I'm not using fractional scaling, but I do have dual-monitors, and Flameshot flashes randomly when I take a screenshot

faedy2 avatar Dec 06 '20 22:12 faedy2

same issue on PopOS 20.10 with 4K screen at 200% scaling captured images are 2x the expected size

I read @borgmanJeremy is making progress....
thanks for that !
hope you'll figure it out soon

dgoosens avatar Dec 08 '20 22:12 dgoosens

Ubuntu 20.04.1 LTS here with Dual HiDPI monitors set to 150% fractional scaling.

Running the very latest Flameshot release (0.8.5) when I try to take a screenshot both my monitors flicker on and off and it becomes actually difficult to break out of.

Has there been any progress addressing this issue? Is there a beta or alpha build we could try?

I have tried this: https://github.com/Mart-Bogdan/flameshot/releases/tag/tmp-fix-scaling-2 and it doesn't work for me.

Same behavior with single monitor and 125% scaling

dotupNET avatar Dec 10 '20 03:12 dotupNET

Same for me at at scale 125% on a dell xps13 with the latest ubuntu (groovy) and all updates installed as of today. Flameshot can only capture a portion of my screen. So it's basically guesswork what gets captured, and anything too much right or bottom is out of the question

kvz avatar Dec 19 '20 19:12 kvz

Same issue with me - Ubuntu 20.04.1 LTS. Tried the temp binary above - no go.

I have a 4k monitor (@125%) & a 1080 (@100%) monitor. When launching flameshot, the screen starts 'rolling'.

Back to Shift-PrtScn for now I guess

Calvin-Browne avatar Dec 21 '20 07:12 Calvin-Browne

As a workaround, I installed gnome-tweak-tool on Ubuntu 20.04 and instead of using fractional scaling in settings, I increased the Scaling Factor in Fonts in Gnome Tweaks settings. A factor of 1.35 worked ok for me using a dual monitor setup with ASUS Designo 27" WQHD IPS DP HDMI 4K.

image

The only thing is that the dash icons were a bit smaller but you can increase the size in Settings -> Appearance -> Icon size.

bitclaw avatar Dec 23 '20 08:12 bitclaw

Same issue with me - Ubuntu 20.10. Tried the temp binary above, same error.

I have only one 4k monitor (@150%) . When launching flameshot, the screen starts 'flashing'.

mrmodolo avatar Jan 04 '21 17:01 mrmodolo

Ubuntu 20.10 user here, 4k monitor at 125% display scaling. Flameshot can only take screenshots of the upper half of my monitor, which is really annoying. It's a super neat tool otherwise, but unfortunately pretty useless for me at the moment... :/

MartinHaeusler avatar Jan 11 '21 09:01 MartinHaeusler

Same problem here. I have two monitors and one of them is in 1.5X scale in the latest version of the XFCE arch.

I really noticed that if I put the primary monitor as the left monitor, the problem happens. If the primary monitor is the one on the right, I can take images of the screen normally.

leonardopn avatar Jan 18 '21 14:01 leonardopn

Same issue as others here - Ubuntu 20.10, 4K hidip monitor, Gnome, running at a fractional scaling factor of 125%.

Flameshot just goes bonkers - screen blanks out for a few seconds, return back, and blanks again. The selection box is limited to 3/4th of the screen.

Please fix this - I loved using Flamshot before but its unusable if one prefers fractional scaling vs the older method of just increasing the text size using GTools

jeetsrs avatar Jan 24 '21 16:01 jeetsrs

i have exactly the same issue with @jeetsrs

Sapemeg avatar Feb 05 '21 15:02 Sapemeg

Same issue as others here - Ubuntu 20.10, 4K hidip monitor, Gnome, running at a fractional scaling factor of 125%.

Flameshot just goes bonkers - screen blanks out for a few seconds, return back, and blanks again. The selection box is limited to 3/4th of the screen.

Please fix this - I loved using Flamshot before but its unusable if one prefers fractional scaling vs the older method of just increasing the text size using GTools

I have similar issues as well

Prashambhuta avatar Feb 20 '21 05:02 Prashambhuta