flameshot icon indicating copy to clipboard operation
flameshot copied to clipboard

Check for updates does not give any feedback/info

Open tessus opened this issue 1 month ago • 7 comments

Flameshot Version

Flameshot v13.3.0 (88c951e) Compiled with Qt 6.9.2 darwin: 24.6.0 macos: 15.7.1

Installation Type

Using the ready-made package from Github Releases

Operating System type and version

macOS 15.7.1 and macOS 26.0.1

Description

Check for updates establishes a connection to api.github.com, but then there is no informational window. e.g. no new version available or Hooray, a new version (x.y.z) is available.

Steps to reproduce

  1. click on flameshot menu item
  2. click on Check for updates
  3. Nothing happens

Screenshots or screen recordings

No response

System Information

MacBook Pro (no external display for this bug)

tessus avatar Oct 29 '25 21:10 tessus

@mmahmoudian I propose if there is not a newer version that this item is not displayed in the menu. In the even there IS a newer version, the menu already directs to the github release page.

I think that makes more sense than the current setup which says "check for update".

And I think its better than simply stating "You have the latest version". That would just clutter the menu.

If thats good with you I can knock it out quickly

borgmanJeremy avatar Oct 30 '25 00:10 borgmanJeremy

Hmm, there are a bunch of options available. Kopia handles it like this:

Image

The menu item is used for manually checking for updates. The item below shows the status. Either when it is done manually or automatically in the background (check for update automatically option in settings).

I honestly have no idea what the best design is and I don't really care as long as some information is provided. Currently I just don't get any info, when clicking on Check for updates. Not when there is an update or when the latest version is already installed.

tessus avatar Oct 30 '25 01:10 tessus

Surprisingly enough, yesterday I faced the same issue but I had bigger fish to fry at the time.

About the solution, although I really like tp automate everything and I like @borgmanJeremy solution, considering that this does make a network call, and so far it is the only network call we have (so far and apart from imgur), I think perhaps it would be nice to have it triggered on demand rather than automatically.

If Flameshot already makes this network call automatically without the user triggering it (I don't remember from the top of my head and I'm not near any computer to check), then let's go with@borgmanJeremy suggestion and simply hide it when the us no newer version, if not, I would then suggest to have it there in the menu and show user a window upon clicking to show the status.

What do you gentlemen think? Which one is more suitable, or is there an alternative that is even better?

mmahmoudian avatar Oct 30 '25 07:10 mmahmoudian

If Flameshot already makes this network call automatically without the user triggering it (I don't remember from the top of my head and I'm not near any computer to check), then let's go with@borgmanJeremy suggestion and simply hide it when the us no newer version, if not, I would then suggest to have it there in the menu and show user a window upon clicking to show the status.

Hmmm, you can only know if there is a new version when you make a call in the background. So the idea of only showing a menu entry or the info that there is a new update, is out of the question, if you want only manual checks. Unless I misunderstood the newly suggested process.

IMO opinion, if you want people to click Check for updates there is no good reason to create a new menu entry below, if there is a new version. A pop up window is more than enough. Unless you store that info locally, so that menu entry will even be available after a restart of the app. Then I'd suggest to make this entry sort of greyed out, but still allow people to click it, so that a browser opens to the new release download page.

tessus avatar Oct 30 '25 07:10 tessus

you can only know if there is a new version when you make a call in the background. So the idea of only showing a menu entry or the info that there is a new update, is out of the question, if you want only manual checks. Unless I misunderstood the newly suggested process.

What I meant was to show a ln item in the menu worded like "check for updates" as you pointed out.

Unless you store that info locally, so that menu entry will even be available after a restart of the app.

As far as I can remember the codebase, the latest released Github version is not stored anywhere.

Then I'd suggest to make this entry sort of greyed out, but still allow people to click it, so that a browser opens to the new release download page.

This also looks like a good approach. I didn't think about this.

mmahmoudian avatar Oct 30 '25 08:10 mmahmoudian

Edit: This was re-written after I first posted it.

We already are doing an automatic check when the user enables it in the configuration. So:

When the user enables automatic check: Remove the menu item when there is not a new update. Rename the button to "Download the latest version" (or something like that)

When user disables automatic check: Always display button. When button is pressed, if a new version is available, redirect user to the download page. If no new version, display a popup that says "Already on the latest version"

Sound okay?

borgmanJeremy avatar Oct 31 '25 16:10 borgmanJeremy

Yes, sounds mostly good to me. 3 comments though:

  1. please show the version instead of "Download the latest version", thus Download version x.y.z in the menu item.
  2. I am not sure if redirecting to the page automatically is a good idea. e.g. if I don't have a browser open, this will open a browser. rather show a popup that shows the new version and add 2 buttons: close and download. the "download" button can open a browser window to the releaase. however, I would just forget about a popup altogether. the code for showing a menu item with the version info (and click action) will be available at that time, so why not use that an show that menuitem below the Check for updates menu item. No need for a popup at all.
  3. I opened this issue, because currently nothing is happening (when there is and when there isn't a new version) when clicking on Check for updates. Isn't this a bug, because this issue only has an enhancement label?

tessus avatar Oct 31 '25 18:10 tessus