flameshot-org
Added a config option to remove the contrast ring around the counting circle tool
This config option removes the contrasting ring around the counting circle tool but enables it again when the user adds an arrow to the circle. I tested it with removing the circle there as well but it looks really unnatural.
I saw someone made a request for the enhancement in #3720 and I already ran it in my own fork of flameshot so decided to give it an actual config option.
@mmahmoudian Do you think this needs a config option? Or do you think we should just pick one as a default?
@borgmanJeremy I believe the outline contrast serves a purpose, but the current version we have is not aesthetically pleasing. I think having a setting is a good middle-ground opinion.
What is your opinion?
@mmahmoudian Okay cool, as long as you think some people want the outline we can keep it behind a config. I think I would prefer the option to fully disable the outline, rather than just when no arrow is drawn. But aesthetics are not my strong suite :)
@FelixJochems would you be able to rebase this off the master branch? That should kick off the CI. Once it passes I can merge it.
@borgmanJeremy in some cases I have also face that the circle is not visible if it is a solid color. In these cases usually a shadow, a glow, or an outline is used. I personally like the shadow option more than the outline (feels more modern), but we should implement shadows for all elements at some point, and then perhaps the outline would not be as useful anymore. The KDE's Spectacle has implemented shadow and few other aesthetics that we can adopt 🤓. Flameshot is way more superior than Spectacle imho, but visually the spectacle looks more appealing in certain features.
@FelixJochems I'm curious to know your opinion as well on the design.
Ooops sorry this is pending me.
I'm good to merge a config for this. IMO I think if config sets the outline to be disabled, the outline should also be disabled when the arrow is drawn. Thoughts on that?
if config sets the outline to be disabled, the outline should also be disabled when the arrow is drawn. Thoughts on that?
Sorry for the delay. I agree. This would be more intuitive. At the moment people would think this is a bug that the outline is not respecting the settings when then arrow is drawn
@FelixJochems Can you make the suggested changes? If not I can implement on a separate PR.