flameshot icon indicating copy to clipboard operation
flameshot copied to clipboard

small changes to make flameshot recognize cosmic desktop

Open manfredlotz opened this issue 1 year ago • 3 comments

this change refers to issue #3680

manfredlotz avatar Sep 15 '24 19:09 manfredlotz

Looks good to me. Thanks for the PR.

mmahmoudian avatar Sep 28 '24 13:09 mmahmoudian

@holazt Any idea why the "OpenSuse Leap 15.6" is failing?

mmahmoudian avatar Sep 28 '24 13:09 mmahmoudian

@holazt Any idea why the "OpenSuse Leap 15.6" is failing?

After this PR https://github.com/flameshot-org/flameshot/pull/3685 merged, the failing can be fixed.

Separate RPM spec into two files: one is for fedora/rehl, another is for opensuse leap

holazt avatar Sep 29 '24 02:09 holazt

Hey folks! Any idea how we can get this unblocked? I'm not a C++ guy...but with some guidance, I can try to figure it out...any idea where I should start? :)

(the logs of the failure have expired...can someone restart the build, maybe?)

jipiboily avatar Apr 16 '25 14:04 jipiboily

I tested this on cosmic alpha 7 and found 2 issues.

1.) Esc does not exit the edit mode 2.) If any desktop scaling is applied (even 200% non fractional) the main widget is incorrectly drawn.

I think this is probably an upstream bug?

borgmanJeremy avatar Apr 27 '25 18:04 borgmanJeremy

There is no damage to existing functions from the modification set. This is just to add a support option so that flameshot will not report errors in this environment. So I think this is a good PR

jack9603301 avatar May 01 '25 15:05 jack9603301

@jack9603301 What error is suppressed after this patch is applied? I did not see a difference in my testing.

borgmanJeremy avatar May 10 '25 21:05 borgmanJeremy