flameshot icon indicating copy to clipboard operation
flameshot copied to clipboard

Added DD-MM-YYYY format option button in configuration menu.

Open YashKale313 opened this issue 1 year ago • 3 comments

Added DD-MM-YYYY format option button in configuration menu.

YashKale313 avatar Aug 31 '24 18:08 YashKale313

Thanks. Since your proposal was to have even number of options, would you please also add the century (or something similar).

mmahmoudian avatar Sep 01 '24 22:09 mmahmoudian

@mmahmoudian Actually the logic that add format buttons ensures that there are even number of formats passed. So before threre were 21 formats (including century) and it was only adding 20 formats excluding century but now since i added 1 it has become 22 formats and its showing all 22 as its even.

YashKale313 avatar Sep 02 '24 07:09 YashKale313

@mmahmoudian Here are the code snippets for your refrence

For adding formats- image

For adding buttons- image

let me know if you feels anything wrong here.

YashKale313 avatar Sep 05 '24 07:09 YashKale313

Hi @mmahmoudian Just checking in if you have reviewd the PR and can it be merged.

YashKale313 avatar Mar 27 '25 06:03 YashKale313

I've build with this patch (it applied clearly) and indeed the new option is available in the config UI

b0ch3nski avatar Apr 01 '25 12:04 b0ch3nski

I no longer have a Windows machine to test on. Does anyone know if this format is compatible on Windows or if it needs to move to an ifdef block?

borgmanJeremy avatar Apr 27 '25 22:04 borgmanJeremy

I no longer have a Windows machine to test on. Does anyone know if this format is compatible on Windows or if it needs to move to an ifdef block?

No ifdef block required for this PR! It adds another numeric date format, which means there is no issue with potential special characters (but I tested if on Windows anyway). IMO this PR can be merged.

Thanks. Since your proposal was to have even number of options, would you please also add the century (or something similar).

I created PR #4033, which makes the button layout creation independent of even/odd number of items in the list, so we won't have to take care about this constraint in future once #4033 is merged.

ElTh0r0 avatar Jun 22 '25 16:06 ElTh0r0

@borgmanJeremy shall I add this to v13 milestone?

mmahmoudian avatar Jun 22 '25 17:06 mmahmoudian