flameshot icon indicating copy to clipboard operation
flameshot copied to clipboard

Add new config option to hide drop shadow around pinned images

Open schwubdiwub opened this issue 2 years ago • 2 comments

Added a new general config option "pinHideDropShadow" which hides the drop shadow around the PinWidget.

Based on this issue #3277

This is my first contribution, so if there is anything missing let me know!

schwubdiwub avatar Dec 02 '23 22:12 schwubdiwub

@mmahmoudian whats your thought on this change?

borgmanJeremy avatar Jun 04 '25 00:06 borgmanJeremy

@schwubdiwub thank you for showing interest in Flameshot and contributing to it. Also, sorry that it took us so long to get to this PR.

My only comment is that in the configuration text and the hint and etc. We should be consistent with the wording (i.e., 'border' -> 'shadow')

@borgmanJeremy i have heard this IRL from friends that they want the glow/shadow to be toggleable. Initially i was somewhat against it if we don't add at least some border, but now that I'm thinking about it, I don't see why not. It is a 12 lines of code and it makes the user experience more customizable. What is your opinion?

The part that we are gradually falling behind is a better organization of options in the configuration window. I should look into this and come up with a proposal on how to make the UI feel less cluttered.

As a general question: how hard is it in Qt/QML to add a fuzzy finder search box at the top of the configuration window, so that typing some keyword would in realtime filter the options?

mmahmoudian avatar Jun 04 '25 05:06 mmahmoudian