flameshot icon indicating copy to clipboard operation
flameshot copied to clipboard

Release checksums are using full file path

Open rzanetti-cpqd opened this issue 2 years ago • 1 comments

Flameshot Version

flameshot-12.1.0-1.ubuntu-20.04.amd64.deb

Installation Type

Using the ready-made package from Github Releases

Operating System type and version

Ubuntu 20.04.4 LTS (Focal Fossa)

Description

Hello I believe there is extra unwanted information on the releases` checksum files.

It shows "{hash} {dir}/{file}" as opposed to "{hash} {file}"

This breaks automated setups that put the file and its checksum on the same directory and run a check to validate its consistency. The workaround is quite simple, as I can crop out the path before checking the sum, but I thought it would be valid to report, as from my understanding this is an unexpected setup.

Thanks

Steps to reproduce

Take a checksum file, for instance flameshot-12.1.0-1.ubuntu-20.04.amd64.deb.sha256sum Check the file path after the hash

Screenshots or screen recordings

image

System Information

Ubuntu 20.04.4 LTS (Focal Fossa)

rzanetti-cpqd avatar Aug 19 '22 15:08 rzanetti-cpqd

yes, I think it is a good suggestion. It is related to the following lines:

  • https://github.com/flameshot-org/flameshot/blob/master/.github/workflows/Linux-pack.yml#L199
  • https://github.com/flameshot-org/flameshot/blob/master/.github/workflows/Linux-pack.yml#L289
  • https://github.com/flameshot-org/flameshot/blob/master/.github/workflows/Linux-pack.yml#L298
  • https://github.com/flameshot-org/flameshot/blob/master/.github/workflows/Linux-pack.yml#L444
  • https://github.com/flameshot-org/flameshot/blob/master/.github/workflows/Linux-pack.yml#L510
  • https://github.com/flameshot-org/flameshot/blob/master/.github/workflows/Linux-pack.yml#L567

mmahmoudian avatar Aug 19 '22 15:08 mmahmoudian