flameshot icon indicating copy to clipboard operation
flameshot copied to clipboard

WIP: Move objects with keyboard

Open vozdeckyl opened this issue 3 years ago • 1 comments

Implements #2490.

However, it still doesn't work 100%. For some reason, the first move is never recorded and I don't know why.

Steps to reproduce:

  1. create an object (rectangle, for example)
  2. select the object by clicking on it
  3. press Shift+Left once
  4. press the undo button
  5. the object disappears instead of moving back to its original position
  6. now repeat steps 1-4, it works this time!

vozdeckyl avatar Jul 07 '22 17:07 vozdeckyl

The issue was fixed by using a different method. The movement is initiated by a key press and stopped by a key release. In order to achieve this, the shortcuts for moving/resizing the selection had to be removed, and its functionality had to be hard-coded. The drawback here is that the user will no longer be able to use different keys for moving/resizing the selection.

vozdeckyl avatar Jul 17 '22 19:07 vozdeckyl

Is this ready for review / merging?

borgmanJeremy avatar Oct 03 '22 17:10 borgmanJeremy

Hi @borgmanJeremy, I think so!

vozdeckyl avatar Oct 03 '22 23:10 vozdeckyl