flameshot icon indicating copy to clipboard operation
flameshot copied to clipboard

Shortcuts not working with not english layout

Open ghost opened this issue 3 years ago • 6 comments

Flameshot Version

Flameshot v11.0.0 (ad1bf28)

Installation Type

Linux, MacOS, or Windows Package manager (apt, pacman, eopkg, choco, brew, ...), Using the ready-made package from Github Releases

Operating System type and version

macOS Monterey 12.1

Description

If keyboard layout is not english, shortcuts in screenshot editor won't work (e.g. Command + A).

Steps to reproduce

No response

Screenshots or screen recordings

No response

System Information

macOS Monterey 12.1

ghost avatar Feb 10 '22 16:02 ghost

You may need to re-map the hot keys for your keyboard. Have you tried that?

borgmanJeremy avatar Feb 18 '22 16:02 borgmanJeremy

@borgmanJeremy I wonder if we can detect the keyboard layout (for example using QLocale::system() or QLocale QApplication::keyboardInputLocale()) and then have some sort of dictionary and map the default shortcuts to those keys.

mmahmoudian avatar Feb 20 '22 08:02 mmahmoudian

From my research into this for registering hotkeys it's orders of magnitudes more complicated than you might expect.

borgmanJeremy avatar Feb 20 '22 12:02 borgmanJeremy

I think this is a bug in Qt itself. I opened a bug and will update here once I hear back

gur111 avatar Feb 22 '22 18:02 gur111

https://bugreports.qt.io/browse/QTBUG-101160 seems to be a little bit abandoned

askazakov avatar Oct 16 '23 08:10 askazakov

It was fixed in version 6.7 Current version Flameshot using Qt 5.15.5 I don't know how hard it is to upgrade to qt6 ...

webdesus avatar Aug 11 '24 11:08 webdesus

We recently ported to qt6 but don't have an official release. Is there any non English speakers who can test a build?

borgmanJeremy avatar Jul 07 '25 22:07 borgmanJeremy

I’m a Hebrew speaker if that helps but far from a power user.

Best regards, Gur Telem.

On Tue, 8 Jul 2025 at 1:03 borgmanJeremy @.***> wrote:

borgmanJeremy left a comment (flameshot-org/flameshot#2406) https://github.com/flameshot-org/flameshot/issues/2406#issuecomment-3046634840

We recently ported to qt6 but don't have an official release. Is there any non English speakers who can test a build?

— Reply to this email directly, view it on GitHub https://github.com/flameshot-org/flameshot/issues/2406#issuecomment-3046634840, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3XPJZHRC4UTSGWHOMJF233HLVDBAVCNFSM6AAAAACA7NWBCCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANBWGYZTIOBUGA . You are receiving this because you commented.Message ID: @.***>

gur111 avatar Jul 07 '25 22:07 gur111

@gur111 would you please follow these steps and report back:

  1. Open Flameshot to take a screenshot.
  2. Confirm that pressing "a" key activates the arrow tool
  3. Select another tool (for example rectangle tool) and draw a rectangle
  4. Change your keyboard layout to any non-english layout
  5. Press the same key as step 2 and see if you can draw an arrow

mmahmoudian avatar Jul 09 '25 06:07 mmahmoudian

@gur111 would you please follow these steps and report back:

  1. Open Flameshot to take a screenshot.
  2. Confirm that pressing "a" key activates the arrow tool
  3. Select another tool (for example rectangle tool) and draw a rectangle
  4. Change your keyboard layout to any non-english layout
  5. Press the same key as step 2 and see if you can draw an arrow

Can you send me a download link for the version you want me to test? I see the newer build on GH is from 2022? I assume it's not that one

gur111 avatar Jul 12 '25 12:07 gur111

@gur111 Although the easiest way is to build from source, but if you want a compiled binary, you can always fetch it from the Artifacts of the latest Github Action. For example:

https://github.com/flameshot-org/flameshot/actions/runs/16227887479#artifacts

mmahmoudian avatar Jul 12 '25 13:07 mmahmoudian

@gur111 Although the easiest way is to build from source, but if you want a compiled binary, you can always fetch it from the Artifacts of the latest Github Action. For example:

https://github.com/flameshot-org/flameshot/actions/runs/16227887479#artifacts

I've downloaded the this (MacOS): https://github.com/flameshot-org/flameshot/actions/runs/16255449329

I'm unable to change tools when using a non-English layout.

gur111 avatar Jul 14 '25 11:07 gur111