flameshot icon indicating copy to clipboard operation
flameshot copied to clipboard

Show selection window's position coordinates in addition to its size

Open eugenesvk opened this issue 4 years ago • 7 comments

Currently flameshow only shows the size/dimensions of the selection rectangle. It'd be nice if it would also show the coordinates, e.g. top-left corner of the selection window is at X,Y, might be a bubble located at the top-left corner screen This helps with repeated screenshots, e.g. if you've missed a few pixels in your original selection, you can remember the position of the previous selection and move your new selection to the exact same spot

eugenesvk avatar Sep 17 '21 08:09 eugenesvk

At the moment you can do flameshot gui --print-geometry to get the coordinates in "W H X Y" format.

But for your use-case, we already have multiple feature requests that are related to your use-case: #1509, #558, #479 I believe these can easily address your need.

If you also agree, please close this issue, if not, please explain the difference.

mmahmoudian avatar Oct 13 '21 07:10 mmahmoudian

https://github.com/flameshot-org/flameshot/issues/479 doesn't work as it's a totally different workflow — cli-based (similarly to your suggestion) https://github.com/flameshot-org/flameshot/issues/558 doesn't specify position, only size

https://github.com/flameshot-org/flameshot/issues/1509 is closer, though is too limited:

  • without the coord info exposed, error correction is harder — what if you inadvertently moved a screenshot area by accidentally pressing a cursor button? You might not notice right away, and it's harder to correct
  • it doesn't work when you need to take another screenshot in-between. For the given example of an application being developed — what if you want to screenshot the exact area two weeks later when a new version is ready? If you have a previous screenshot app v1_x10y10h600v400.png saved you could just enter the same position/coordinates in the GUI and have an identical screenshot

eugenesvk avatar Oct 14 '21 03:10 eugenesvk

I suggest the following changes to address this issue:

  • Selection geometry indicator while it is being moved/resized This can be implemented in one of 2 ways:
    • Extend the top-left-corner notifier box that shows tool size (thickness) so it shows the geometry of the selection while the selection is being moved.
    • While resizing the selection: show the top-left corner coordinates next to the top-left corner of the selection, and show 'WIDTHxHEIGHT' in the middle of the selection (possibly with a large text size). The coordinates and WIDTHxHEIGHT should be repositioned intelligently so they don't get clipped by screen boundaries and to avoid other edge cases.
  • Make the size indicator (the button that appears alongside the selection, not the notifier box) clickable. When you click it, you can enter the precise geometry (x, y, width, height)

All are compatible with the suggestions in the linked issues.

veracioux avatar Oct 14 '21 11:10 veracioux

Make the size indicator (the button that appears alongside the selection, not the notifier box) clickable.

Imho this would be good if the settings open in the side bar. Would be extra nice if pasting X.Y.W.H (whatever delimiter we ultimately decide to go with instead of . ) fills all the boxes in one go. What do you think?

mmahmoudian avatar Oct 14 '21 19:10 mmahmoudian

@mmahmoudian Excellent. If we replace the "Active thickness: " + slider with a text box to change selection geometry when no tool is selected, then we would solve another problem. Namely that the slider doesn't affect any value if no tool is selected. This confused the heck out of me, but I keep forgetting to report it.

Currently I don't have an opinion about the format/delimiter.

veracioux avatar Oct 14 '21 19:10 veracioux

Namely that the slider doesn't affect any value if no tool is selected

This was also very confusing for me but now my brain ignores it 😅 I don't mind about the delimiter and as someone in another thread suggested with that regex, any non-digit delimiter would be fine I assume.

mmahmoudian avatar Oct 18 '21 15:10 mmahmoudian

This should be added via comments on #2766

borgmanJeremy avatar Jul 07 '22 00:07 borgmanJeremy

I think this is fully implemented in #2766 . I am closing this issue. If you think there is still something missing, please consider re-opening and commenting.

mmahmoudian avatar Dec 28 '22 10:12 mmahmoudian