libflame icon indicating copy to clipboard operation
libflame copied to clipboard

Make sure `lsame_` is exported

Open mmuetzel opened this issue 3 years ago • 0 comments

The reference (netlib) LAPACK implementation exports lsame_ unconditionally. When trying to use libflame as a drop-in replacement for the reference implementation on Windows, programs fail to start with an error that the symbol lsame_ is undefined. IIUC, that is because the symbol resolution is done on link time for Windows (instead of at runtime on most other platforms).

The proposed change makes sure that lsame_ is exported from libflame even if configured with --disable-lapack2flame --disable-builtin-blas (the default).

IIUC, an alternative would be to export this symbol defined in src/flablas/f2c/lsame.c. But the proposed change is a bit closer to the reference implementation.

See also this downstream report: https://savannah.gnu.org/bugs/index.php?63184

mmuetzel avatar Oct 10 '22 08:10 mmuetzel