blis icon indicating copy to clipboard operation
blis copied to clipboard

Use intrinsics for all sifive_x280 kernels

Open myeh01 opened this issue 1 year ago • 3 comments

To address a bug encountered in #805, this PR converts all kernels in the sifive_x280 configuration written in inline assembly to intrinsics.

myeh01 avatar Aug 01 '24 09:08 myeh01

If you check the CI/CD build, you see one compiler error.

kernels/sifive_x280/1/bli_invscalv_sifive_x280_intr/./bli_invscalv_sifive_x280_intr_complex.c:68:43: fatal error: call to undeclared function '__riscv_vundefined_f32m4x2'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]

leekillough avatar Aug 04 '24 03:08 leekillough

Integer types (size_t, guint_t, int) are mixed; some occurrences do not have a type conversion. This would be problem if potentially unsafe integer conversions were disallowed. However, I think that this is an issue throughout BLIS.

leekillough avatar Aug 04 '24 03:08 leekillough

Wow, quite a lot of work. Thanks @myeh01. @fgvanzee unless you have any comment I'll merge this since everything is passing.

devinamatthews avatar Oct 04 '24 18:10 devinamatthews