flame icon indicating copy to clipboard operation
flame copied to clipboard

chore: Update audioplayers to ^6.0.0 in flame_audio

Open ufrshubham opened this issue 1 year ago • 6 comments

Description

This PR updates the audioplayers version for flame_audio.

Checklist

  • [x] I have followed the Contributor Guide when preparing my PR.
  • [ ] I have updated/added tests for ALL new/updated/fixed functionality.
  • [ ] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [ ] I have updated/added relevant examples in examples or docs.

Breaking Change?

  • [ ] Yes, this PR is a breaking change.
  • [x] No, this PR is not a breaking change.

Related Issues

Closes #3151 and #3157

ufrshubham avatar May 15 '24 06:05 ufrshubham

I thought there were some breaking changes we had to adhere to, but seemingly not? 🤔

spydon avatar May 15 '24 06:05 spydon

I thought there were some breaking changes we had to adhere to, but seemingly not? 🤔

I didn't notice any breaking change in flame_audio, but I am getting some conflicts with multiple definitions of the Split class.

ufrshubham avatar May 15 '24 07:05 ufrshubham

I thought there were some breaking changes we had to adhere to, but seemingly not? 🤔

I didn't notice any breaking change in flame_audio, but I am getting some conflicts with multiple definitions of the Split class.

Aaah right, that is due to the devtools extension, I'll migrate that when I get home from Google I/O (the name changed in the new version).

spydon avatar May 15 '24 18:05 spydon

Aaah right, that is due to the devtools extension, I'll migrate that when I get home from Google I/O (the name changed in the new version).

Okay, I'll leave it up to you then. I tried hiding the other definition but now it fails analyze saying Split is not exported.

ufrshubham avatar May 15 '24 19:05 ufrshubham

Okay, I'll move that change into a separate PR tomorrow

ufrshubham avatar May 15 '24 19:05 ufrshubham

Moved the dart sdk bump to #3160

ufrshubham avatar May 16 '24 06:05 ufrshubham