fundus icon indicating copy to clipboard operation
fundus copied to clipboard

Feature/add motorsport magazin

Open lsch0lz opened this issue 1 year ago • 6 comments

Hi! I added the MotorSport Magazin LINK to fundus 🚀

Note: Black reformatted several files, that I didn't intent to touch. Let me know, if thats OK for you

lsch0lz avatar Apr 24 '24 20:04 lsch0lz

Hi! @addie9800 I added the correct summary and subheadline selectors. Also the class now has a topics() method.

lsch0lz avatar Apr 26 '24 16:04 lsch0lz

Hi! @addie9800 I added the correct summary and subheadline selectors. Also the class now has a topics() method.

Thanks a lot ;) this looks really good. Black seems really weird, when I run black locally it reformats the file back. But I'll just approve the workflow and we'll see if the test go through.

addie9800 avatar Apr 26 '24 17:04 addie9800

Sounds good!

lsch0lz avatar Apr 26 '24 19:04 lsch0lz

@lsch0lz Could you tell me what version of black is installed in your environment?

@addie9800 The tests won't trigger. The last commit on this branch 29c4a5c3f1e1bfc67704bb93ff41c8f6044f38d5 was auto-committed and due to GitHubs limitations, those won't trigger workflow runs.

MaxDall avatar Apr 27 '24 11:04 MaxDall

@MaxDall I have the newest black version (24.4.2) installed. Just checked and black . doesn't reformat any of the code locally

lsch0lz avatar Apr 27 '24 16:04 lsch0lz

@lsch0lz Thanks :) We pinned the Black version for the repository and are currently at 23.1.0. I'm gonna reformat with 23.1.0 and push on your branch. Then this should be good to go 👍

MaxDall avatar Apr 28 '24 19:04 MaxDall