flair icon indicating copy to clipboard operation
flair copied to clipboard

Fixes the incorrect token prediction distribution from _all_scores_for_token() in sequence_tagger_model.py

Open mdmotaharmahtab opened this issue 1 year ago • 3 comments

This PR fixes the issue #3448 . Previously, due to incorrect length calculation for each sentence in the batch, the returned tag probability distribution for each token was incorrect (from the _all_scores_for_token() function in sequence_tagger_model.py). This PR makes a small change in _all_scores_for_token() function to correctly compute the length.

mdmotaharmahtab avatar May 01 '24 16:05 mdmotaharmahtab

@mdmotaharmahtab thanks a lot for this PR!

@whoisjones can you review?

alanakbik avatar May 02 '24 07:05 alanakbik

I have examined the failing unit tests and found that they also failed on the master branch (so rebasing on the master did not help). They may not be related to this PR. Do I need to work on these tests for this PR? @whoisjones @alanakbik

mdmotaharmahtab avatar May 04 '24 05:05 mdmotaharmahtab

Hello. Want to know if this PR will be reviewed any time soon? @whoisjones @alanakbik

MdMotahar avatar Aug 06 '24 10:08 MdMotahar