Results 87 comments of flagarde

@LecrisUT Does everything looks fine now?

> I don't know how to test this case

```cmake cmake_minimum_required(VERSION 3.24) project(TestCPMFetchContent) include(FetchContent) FetchContent_Declare(CPM GIT_REPOSITORY https://github.com/flagarde/CPM.cmake GIT_TAG FetchContent ) FetchContent_MakeAvailable(CPM) find_package(CPM) # the install option has to be explicitly set to allow installation CPMAddPackage( GITHUB_REPOSITORY jarro2783/cxxopts VERSION 2.2.1...

> Of course, but that's the intended behaviour smile The warning I get there is: > > ``` > CMake Warning at cmake-build-debug/_deps/cpm-src/cmake/CPM.cmake:80 (message): > CPM: Your project is using...

> > ```cmake > > cmake_minimum_required(VERSION 3.24) > > project(TestCPMFetchContent) > > > > include(FetchContent) > > FetchContent_Declare(CPM > > GIT_REPOSITORY https://github.com/flagarde/CPM.cmake > > GIT_TAG FetchContent > > ) >...

maybe a NO_POLICY_SCOPE in include(cmake/CPM.cmake) would be safer as we set some policy

> > maybe a NO_POLICY_SCOPE in include(cmake/CPM.cmake) would be safer as we set some policy > > I don't know about this. I defer to others on this. > >...

Oh. Interesting but this is a very new feature. Maybe you can try wil the actual code and check of people have problem.. A cache variable could be a solution....

> Yes +1 from me. These stuff are just QOL improvements we can do later. > > You still need a proper reviewer to accept and cmake-format it. Wonderful, let's...

> Hey thanks for the PR! To be sure I understand, the idea of this is to allow using `FetchContent` to shorten the required code for integrating CPM.cmake in a...