flack

Results 60 comments of flack

@morozov ok, I've cobbled something together with which I can reproduce locally: ```php $table = new Table('"tester"'); $table->addColumn('"id"', Types::INTEGER); $table->addColumn('"name"', Types::STRING); class testclass {} $cm = new ClassMetadata(testclass::class); $cm->setTableName('tester'); $cm->setIdentifier(['id']);...

@morozov try this: ```php $table = new Table('"tester"'); $table->addColumn('"id"', Types::INTEGER); $table->addColumn('"name"', Types::STRING); $schemaManager = $conn->createSchemaManager(); $schemaManager->dropAndCreateTable($table); $current_schema = $schemaManager->createSchema(); $to_schema = new Schema(); $t2 = $to_schema->createTable('tester'); $t2->addColumn('"id"', Types::INTEGER); $t2->addColumn('"name"', Types::STRING);...

@morozov thx, that fixed the issue for me. But I suppose for @Rixafy's issue some analoguous change would have to be made in some Nette component

btw, I guess the dbal docs also needs to be updated, e.g. here it still says `new Comparator` in the code sample: https://github.com/doctrine/dbal/blob/f57646665700d833054d1ac597cd28a19e9f35a3/docs/en/reference/schema-representation.rst#L50

Hi! I just stumbled across this ticket because I was about to file the same request :-) @adjohu: What state is your code in, do you think it could be...

another example of the same issue: ![Screenshot_20230522_154031](https://github.com/eclipse/pdt/assets/425166/e9148ba5-8de7-4695-a755-c48518306839)

would be nice if a click on a row where the dialog is already open would bring that dialog to the foreground

just wanted to add that we've stumbled across this problem, too. It basically affects all JS modules, e.g. modal, collapse, etc. As soon as the ID has anything in it...

Does this umbrella issue also cover `class_alias`? Because it would be great if that could be made to work, too:

I can get rid of most of the notices by applying this diff: ```diff diff --git a/wp-content/plugins/give/includes/payments/actions.php b/wp-content/plugins/give/includes/payments/actions.php index 7cc64e11a..f5ed2320f 100644 --- a/wp-content/plugins/give/includes/payments/actions.php +++ b/wp-content/plugins/give/includes/payments/actions.php @@ -362,7 +362,7 @@ function...