astexplorer icon indicating copy to clipboard operation
astexplorer copied to clipboard

acorn 6 and acorn-loose

Open othree opened this issue 7 years ago • 2 comments

Hi

Acorn 6 just released, and acorn-loose is a seperate package now. I plan to send a PR to add these two parser. But not sure how to name it.

My idea now is:

  • Current acorn rename to acorn 5
  • Add new acorn (version 6)
  • Add new acorn-loose (version 6)

But this naming is not align with other parsers, ex babel-eslint. Do you have any idea?

othree avatar Sep 27 '18 03:09 othree

I actually want to move away from exposing different parser versions with different names. Instead I want there to be a single adapter for each parser (i.e. babelyon, acorn, ...) that can load and handle different versions of a parser.

In other words, I want to consolidate all different parserX files into single parser files.

I'm actually starting out with acorn as my guinea pig, so I can take care of v6.

Wrt acorn-loose: I'm not quite sure. Loose mode has already been a separate file but we just made it look like an option. I guess the question is, can acorn-loose evolve independently from acorn, or whether it is just a derivative. If the former it should be a new parser.

fkling avatar Sep 27 '18 21:09 fkling

acorn-loose is a depend on acorn, they share some codes. But acorn-loose is not a special mode or option of acorn 6.

othree avatar Sep 28 '18 13:09 othree