FACT_core icon indicating copy to clipboard operation
FACT_core copied to clipboard

Update pylint configuration for pylint 2.0

Open maringuu opened this issue 1 year ago • 1 comments

Most options were just explicitly configured as their default. To simplify the configuration everything that was unchanged is removed.

See https://pylint.pycqa.org/en/latest/user_guide/configuration/all-options.html

Also some options were deprecated and do not exists in pylint 2.0 anymore. I set the maximum line width to 120 as this is what I can comfortably read on my 27" 2k display in one half of the screen. Any opinions on line length?

maringuu avatar Aug 16 '22 13:08 maringuu

Ping @jstucke

maringuu avatar Sep 20 '22 06:09 maringuu

Any opinions on line length?

Coincidentally, that is also my preferred maximum line length. Do we need to upgrade the pre-commit hook?

jstucke avatar Sep 26 '22 11:09 jstucke

It seems to bionic_venv only failed because of a timeout that was set too tightly.

jstucke avatar Sep 26 '22 11:09 jstucke

It seems some options were changed by removing them because they were not configured with their default value:

  • load-plugins
  • max-args=7
  • max-complexity=7
  • min-public-methods=0
  • max-public-methods=40

and many more. Was this intentional?

jstucke avatar Sep 27 '22 12:09 jstucke

I documented all options that changed in the commit messsage. All other options were explicitly set to their default value before.

Also the configuration is now done in pyproject.toml.

maringuu avatar Oct 04 '22 10:10 maringuu