FACT_core
FACT_core copied to clipboard
Move plugin results to nested dictionary in processed_analysis structure
References #799
Ready for review. Three tests still fail, but I cant figure out why.
src/plugins/analysis/software_components/test/test_plugin_software_components.py::TestAnalysisPluginsSoftwareComponents::test_process_object
src/test/unit/analysis/test_yara_plugin_base.py::TestAnalysisYaraBasePlugin::test_process_object
src/test/unit/analysis/test_yara_plugin_base.py::TestAnalysisYaraBasePlugin::test_process_object_nothing_found
Three tests still fail, but I cant figure out why.
src/plugins/analysis/software_components/test/test_plugin_software_components.py::TestAnalysisPluginsSoftwareComponents::test_process_object
in src/plugins/analysis/software_components/code/software_components.py
line 43
if len(result) > 1:
the 1
must be changed to a 0
because the summary is no longer in the same dict
src/test/unit/analysis/test_yara_plugin_base.py::TestAnalysisYaraBasePlugin
in src/test/unit/analysis/test_yara_plugin_base.py
the functions test_process_object
and test_process_object_nothing_found
do not consider that the results are stored under the new 'result'
key
@maringuu Since we decided to postpone this until Q1 2023 this should be marked appropriately. Also it will not be merged into database-migration anymore but either master or more likely a dedicated analysis dev branch.
Superseeded by #987 and its follow ups.