FACT_core icon indicating copy to clipboard operation
FACT_core copied to clipboard

Move plugin results to nested dictionary in processed_analysis structure

Open maringuu opened this issue 2 years ago • 2 comments

References #799

maringuu avatar Jun 20 '22 08:06 maringuu

Ready for review. Three tests still fail, but I cant figure out why.

src/plugins/analysis/software_components/test/test_plugin_software_components.py::TestAnalysisPluginsSoftwareComponents::test_process_object
src/test/unit/analysis/test_yara_plugin_base.py::TestAnalysisYaraBasePlugin::test_process_object
src/test/unit/analysis/test_yara_plugin_base.py::TestAnalysisYaraBasePlugin::test_process_object_nothing_found

maringuu avatar Jun 22 '22 13:06 maringuu

Three tests still fail, but I cant figure out why.

src/plugins/analysis/software_components/test/test_plugin_software_components.py::TestAnalysisPluginsSoftwareComponents::test_process_object

in src/plugins/analysis/software_components/code/software_components.py line 43 if len(result) > 1: the 1 must be changed to a 0 because the summary is no longer in the same dict

src/test/unit/analysis/test_yara_plugin_base.py::TestAnalysisYaraBasePlugin

in src/test/unit/analysis/test_yara_plugin_base.py the functions test_process_object and test_process_object_nothing_found do not consider that the results are stored under the new 'result' key

jstucke avatar Jul 11 '22 07:07 jstucke

@maringuu Since we decided to postpone this until Q1 2023 this should be marked appropriately. Also it will not be merged into database-migration anymore but either master or more likely a dedicated analysis dev branch.

dorpvom avatar Oct 11 '22 08:10 dorpvom

Superseeded by #987 and its follow ups.

maringuu avatar Apr 17 '23 06:04 maringuu