FACT_core icon indicating copy to clipboard operation
FACT_core copied to clipboard

Unpack and analysis timeouts

Open njv299 opened this issue 6 years ago • 2 comments

Most of the plugins invoke external applications via the execute_shell_command() helper function. This function provides an optional parameter of timeout, which defaults to None (aka no timeout). It would be useful to be able to set this dynamically for each unpacker to prevent having the system choke on files that take unexpectedly long times.

I propose that each unpacker's unpack_function() is modified to take an additional optional timeout parameter (which defaults to None), and the unpacking scheduler can set this value via customization of the main.cfg file.

The same process could be done for the Analysis plugins, but they have direct access to the config object and therefore could each manually check for a timeout configuration value.

njv299 avatar Feb 28 '19 21:02 njv299

We are going to make some major changes regarding the backend in the near future. We will have a look if we can implement this feature during the process.

weidenba avatar Mar 16 '19 16:03 weidenba

This is generally possible, though it should be noted that

a) this practically means an additional (monitoring) process for each unpacker b) the timeout can hardly be set statically since some files might take reeeaaally long (i.e. binwalk on large files) while other plugins should already time out after a couple of seconds

I guess Peter refers to the standalone extractor [1] [2] by the way

dorpvom avatar Mar 19 '19 14:03 dorpvom