FACT_core
FACT_core copied to clipboard
print out fact version + git hash on start
- log fact version, git commit hash and python version on startup of each component
- should help debugging some of the bare logs we get in GitHub issues
Depending on gitpython installed (which in turn requires git) makes FACT even less packagable. This is not a problem per se, as FACT currently cannot be packaged anyway but I think we should have packaging in mind. I'd prefer if we dropped the gitpython dependency and use just git. In addition, FACT should not crash if git is not installed.
Why should gitpython be a problem but not git (since it is a pip package)? Also I think we can assume that git is installed if FACT is installed (since it gets used a lot during the installation and is explicitly installed in the pre_install.sh
).
Why should gitpython be a problem but not git [...]?
It is not a problem per-se, but I do not like adding dependencies for stuff that can be done in one line without the dependency.
I replaced gitpython with a call to git