FACT_core icon indicating copy to clipboard operation
FACT_core copied to clipboard

print out fact version + git hash on start

Open jstucke opened this issue 8 months ago • 3 comments

  • log fact version, git commit hash and python version on startup of each component
    • should help debugging some of the bare logs we get in GitHub issues

jstucke avatar Dec 15 '23 09:12 jstucke

Depending on gitpython installed (which in turn requires git) makes FACT even less packagable. This is not a problem per se, as FACT currently cannot be packaged anyway but I think we should have packaging in mind. I'd prefer if we dropped the gitpython dependency and use just git. In addition, FACT should not crash if git is not installed.

Why should gitpython be a problem but not git (since it is a pip package)? Also I think we can assume that git is installed if FACT is installed (since it gets used a lot during the installation and is explicitly installed in the pre_install.sh).

jstucke avatar Jan 09 '24 17:01 jstucke

Why should gitpython be a problem but not git [...]?

It is not a problem per-se, but I do not like adding dependencies for stuff that can be done in one line without the dependency.

maringuu avatar Feb 22 '24 15:02 maringuu

I replaced gitpython with a call to git

jstucke avatar Feb 28 '24 09:02 jstucke