FACT_core refactor: Drop dependency on fact_helper

This uses https://github.com/maringuu/fact-mime-database which is imo the only relevant thing that fact_helper_file provides.

Before merging we should somehow incoperate that fact_helper_file/mime/custom_mime_internal is missing. If would be great if we could add this somehow add to the FACT_core repo to make fact-mime-database not use its generality.

Oct 10 '23 08:10 maringuu

While I don't really care note that the repo is in my namespace and not fkiecad's.

Oct 10 '23 09:10 maringuu

This is blocked on https://github.com/ahupp/python-magic/pull/304 which allows us to delete helperFunctions/magic.py completely. Edit: To actually get rid of it we also need to solve https://github.com/ahupp/python-magic/issues/305

Oct 12 '23 10:10 maringuu

Seems that I and the python-magic developer disagree on what a good public API for the magic module would be. I updated our magic wrapper to be what I wanted in pymagic's API.

Regarding the FACT extractor I don't think we need to copy this code since the only thing it ever needs is Magic.from_file(path, mime=true). So it could just provide a global instance of magic.Magic and everything works as expected. If we even used the MAGIC environment variable to specify where the additonal magic database is, we can just use magic.from_file instead of creating an instance of Magic.

Oct 18 '23 15:10 maringuu

Assuming that https://github.com/fkie-cad/fact_extractor/pull/128 works and is merged this is ready for review.

Nov 07 '23 09:11 maringuu

@jstucke Assuming the CI passes, this should be mergeable as is.

Assuming that https://github.com/fkie-cad/fact_extractor/pull/128 works and is merged this is ready for review.

Note that this is not true. Why shouldn't we drop a dependency when we can?!

Aug 01 '24 12:08 maringuu

refactor: Drop dependency on fact_helper_file