react-on-screen icon indicating copy to clipboard operation
react-on-screen copied to clipboard

Make offset prop a flexible unit

Open HemalR opened this issue 6 years ago • 2 comments

It would be very useful for responsive design to have the offset prop be a string which would allow units to be flexible. I.e. - Instead of specifying the px height we could specify e.g. a vh unit, or rems or whatever...

Thoughts/workaround?

HemalR avatar Jan 24 '19 05:01 HemalR

Hello,

Indeed sounds like a good idea. Do you want to make a PR for this ?

fkhadra avatar Jan 25 '19 14:01 fkhadra

Noobie dev who doesn't know how to do a PR 😬

Perfect time to learn I guess. I'll give it a whack!

HemalR avatar Feb 04 '19 00:02 HemalR