react-contexify icon indicating copy to clipboard operation
react-contexify copied to clipboard

Make preventing default on keydown optional - Fixes #168

Open DavidHooper opened this issue 3 years ago • 1 comments

Preventing default on keydown causes all inputs on the page to stop working whilst the Menu component is mounted. Some apps have the menu mounted whilst not in use, causing inputs to stop working.

Adds a flag to disable this feature and also makes it work as intended only for keys required for operating the menu that may cause the window to scroll.

Related issue #168

Before submitting a pull request, please make sure the following is done:

  1. Fork the repository and create your branch from master.
  2. Run yarn in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Run yarn start in the example folder to test your changes.
  5. Ensure the test suite passes (yarn test). It uses the example
  6. Update the readme if needed or the documentation
  7. Update the typescript definition is needed
  8. Make sure your code lints (yarn lint --fix).

Learn more about contributing here

DavidHooper avatar Mar 12 '21 03:03 DavidHooper

why this not merge into?

danny-wang avatar Mar 07 '22 09:03 danny-wang