jimple icon indicating copy to clipboard operation
jimple copied to clipboard

Published 20 hours ago • verified publisher icon fjorgemota

isFunction is not compatible with IE11

Open Poyoman39 opened this issue 4 years ago • 2 comments

Hey.

The internal "isFunction" function is not compatible with IE11, on which "fn.constructor.name" will return undefined. Causing this library doesn't work at all on IE11

Poyoman39 avatar Nov 25 '19 16:11 Poyoman39

Hey.

Given that IE11 doesn't support ES6 (which is used by this library), I don't think this library should be adapted to support it, too, specially considering that IE11 isn't supported even by Microsoft, which used to develop it..

fjorgemota avatar Nov 30 '19 22:11 fjorgemota

I agree with you. However it looks like most of your this is compatible with IE11 except this core functionality. I made a PR which is a potential simplification of this function. Feel free to integrate or not ;)

Poyoman39 avatar Dec 02 '19 09:12 Poyoman39