wowchat icon indicating copy to clipboard operation
wowchat copied to clipboard

Allow Tag feature enable/disable as a configuration

Open JoPeAlmeida opened this issue 3 years ago • 6 comments

I want to disable the tag feature This should something we could enable/disable in configurations

The main issue why I'm asking this is because if someone uses @ by mistake and the tag failed (matches too many) then the message is not sent to discord

JoPeAlmeida avatar Mar 03 '22 09:03 JoPeAlmeida

i tried use filters to filter @ but it doesn't work, error message is still sent, ignoring any filter

JoPeAlmeida avatar Mar 10 '22 09:03 JoPeAlmeida

that's not how the code works. the message will still be sent to discord without tagging anyone. you can disable the "matches too many" notification by setting enable_tag_failed_notifications=0 in the config

fjaros avatar Mar 12 '22 22:03 fjaros

the only message sent to discord is this one: Your tag @s matches too many channel members. Be more specific in your tag!

enable_tag_failed_notifications=0 wouldn't this make it enabled? i don't want the bot whispering random people from global this warning

 # If a tag matching fails from Discord when someone @ a non-existent or unmatched person or role,
 # the bot will whisper back notifying so.
 enable_tag_failed_notifications=1

this is what is written in the about this config

JoPeAlmeida avatar Mar 13 '22 19:03 JoPeAlmeida

that's not how the code works. the message will still be sent to discord without tagging anyone. you can disable the "matches too many" notification by setting enable_tag_failed_notifications=0 in the config

I understand that's not how the code works, that's why I am asking this as a feature a new specific config that disables/enables tagging

JoPeAlmeida avatar Mar 13 '22 19:03 JoPeAlmeida

That's fine. I don't consider this a high priority though. Since to solve your problem, all you have to do is set enable_tag_failed_notifications=0 to disable warnings about matching too many tags. Then, only the message itself will be sent to discord without any tags being applied.

fjaros avatar Mar 13 '22 20:03 fjaros

i am trying this, so far nothing but this was not happening that often, so lets see

thanks for the help and for considering this a maybe feature ;)

JoPeAlmeida avatar Mar 13 '22 20:03 JoPeAlmeida