cloudhopper-smpp icon indicating copy to clipboard operation
cloudhopper-smpp copied to clipboard

Test methods createClientConfigurationWeakSSL() and createClientConfigurationWeakSSL() have the same body

Open informatik01 opened this issue 4 years ago • 1 comments

Hi.

Noticed that two helper methods in the SslSessionTest class despite having different names have the same body (and the same logic). I am meant the following methods:

Was is done on purpose for some reason or it was accidently left like this?

informatik01 avatar Dec 31 '21 16:12 informatik01

The related test method trustedClientSSL() is currently marked with @Ignore annotation because it fails with the current incorrect implementation of the createClientConfigurationStrongSSL() helper method.

I managed to update the code of the createClientConfigurationStrongSSL() helper method to successfully run the trustedClientSSL() test method: added the missing SSL configurations and imported a self-made certificate into the keystore used in the tests.

At least I am satisfied with the result 😊.

informatik01 avatar Dec 31 '21 16:12 informatik01