Benjamin Horsleben

@jwfriese I would love for pending tests to be visible. I always spec out the expected behaviour with pending `it`s first, and then start implementing the tests one by one,...

That's not true. The current version incorrectly claims that Flow does not support the concept of both public and private properties; it most certainly does, and it enforces this on...

This seems a common issue with CLI apps. `ls -5` gives error `ls: illegal option -- 5`. The solution there is `ls -- -5`. That solution seems to also work...

@weissi I think you are confusing values for arguments with arguments. In your example, `[-D format]` is the argument you are triggering, not `-D` followed by `-1`. The parser can...

@weissi No problem, it happens to everyone :). You are correct though in that `ls` has an argument `-1`: ``` -1 (The numeric digit “one”.) Force output to be one...

Regarding the failing test, it reacts to the change of type. But since `[UInt8]` conforms to `DataProtocol` (which for the record is `protocol DataProtocol : RandomAccessCollection where Self.Element == UInt8,...

> Why wasn't this changed in the Concurrency shims as well? > > https://github.com/vapor/websocket-kit/blob/4232d34efa49f633ba61afde365d3896fc7f8740/Sources/WebSocketKit/Concurrency/WebSocket%2BConcurrency.swift#L15 I didn't know that overload existed until you told me about it. I stumbled on the...

Is this something you want me to do in this PR, or would it make more sense to take these changes as-is and revisit the leftovers later?

Are you sure about `extra` and `tags` being nullable? 1. The convenience constructors at https://github.com/getsentry/raven-objc/blob/master/Raven/RavenClient.m#L115-L121 pass in `@{}` instead of `nil` 2. At https://github.com/getsentry/raven-objc/blob/master/Raven/RavenClient.m#L365 and https://github.com/getsentry/raven-objc/blob/master/Raven/RavenClient.m#L370, they are used as...

I am fine with the server being more lax than the client. I would actually prefer the dictionaries to be non-nil, as it makes the client API easier to work...