ra-customizable-datagrid icon indicating copy to clipboard operation
ra-customizable-datagrid copied to clipboard

Support for translated field names

Open gstvg opened this issue 5 years ago • 5 comments

Does this component support translated labels? I'm using it with a translated admin but on dialog selection field names are not translated.

gstvg avatar Dec 10 '19 03:12 gstvg

Hello @gstvg ,

No, but this behavior should be easy to add. Please feel free to submit a PR.

https://github.com/fizix-io/ra-customizable-datagrid/blob/master/src/CustomizableDatagrid.js#L46

add withTranslate HOC: https://github.com/marmelab/react-admin/blob/master/docs/Translation.md#withtranslate-hoc and use label: translate(...

AkselsLedins avatar Dec 10 '19 03:12 AkselsLedins

#5 fix this

gstvg avatar Jan 28 '20 16:01 gstvg

@AkselsLedins

gstvg avatar Feb 03 '20 21:02 gstvg

Hello @AkselsLedins ,

It looks like https://github.com/fizix-io/ra-customizable-datagrid/pull/5 fixes this issue. When you have a chance, could you please review and merge that Pull Request?

Thank you!

hardingmatt avatar Apr 23 '20 01:04 hardingmatt

Hi @AkselsLedins ,

It would be extremely helpful to have this fixed. Could you please take a look at this one-line fix, when you have a chance? Thank you!

https://github.com/fizix-io/ra-customizable-datagrid/pull/5/files

hardingmatt avatar Oct 21 '20 19:10 hardingmatt