clpy icon indicating copy to clipboard operation
clpy copied to clipboard

Test for ultima

Open LWisteria opened this issue 6 years ago • 6 comments

There is no test for ultima itself. That absence could be problem.

LWisteria avatar Feb 17 '19 08:02 LWisteria

@vorj I request you to try this issue.

LWisteria avatar Feb 17 '19 08:02 LWisteria

@LWisteria I made the template of test case for ultima in #202. Then, what should we check? Please let me know your opinion.

These are the test cases what I conceived:

  • General conversions
    • [x] Type cast
      • [x] Function style cast
      • [x] C++ cast
    • [x] Constructor
    • [x] Template instantiation
    • [x] Overload mangling
    • [x] Tricking half
  • Specific Conversions
    • [x] CArray<T, N> to __global T*, CArray_N
    • [ ] Operator overloading for CArray
    • [x] Member functions for CArray and CIndexer
    • [ ] Header name mutation
    • [ ] Begin/end print out directives
    • [ ] Elementwise/reduction kernel conversion

vorj avatar Feb 28 '19 11:02 vorj

@vorj Firstly, do not send the big PR which contains whole cases. #202 (and a item you wrote above) is enough to merge. So please make those tests.

On the other hand, I will check the test cases, at latest before you finish the above cases.

LWisteria avatar Mar 01 '19 03:03 LWisteria

Anyway, this issue is not on the beta2 milestone thus #153 's priority is higher.

LWisteria avatar Mar 01 '19 03:03 LWisteria

OK, so I will create those test cases later.

vorj avatar Mar 14 '19 03:03 vorj

@vorj The file for ultima test will be large. How about making ultima_tests directory and dividing them into each file by test type?

LWisteria avatar May 14 '19 00:05 LWisteria