dbt_netsuite icon indicating copy to clipboard operation
dbt_netsuite copied to clipboard

[Feature] Allow downstream filtering on transaction booleans in model netsuite2__transaction_details

Open FrankTub opened this issue 3 months ago • 7 comments

Is there an existing feature request for this?

  • [X] I have searched the existing issues

Describe the Feature

I would like to use model netsuite2__transaction_details in downstream models that I create in my own project. To do it in an efficient way I would like to be able to filter on at least the following columns.

  • is_main_line
  • is_tax_line
  • is_closed

Describe alternatives you've considered

Misuse transaction_lines_pass_through_columns and create your own column that is passed through.

Are you interested in contributing this feature?

  • [X] Yes.
  • [ ] Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • [ ] No.

Anything else?

No response

FrankTub avatar Mar 26 '24 17:03 FrankTub

Hi @FrankTub thanks for opening this and highlighting your use case, in addition to opening that PR!

We've added this to our backlog and will pick this up when our team has availability.

fivetran-reneeli avatar Mar 27 '24 19:03 fivetran-reneeli

@fivetran-reneeli , do you have an indication on how long such a PR will take? If it takes some more time I will have to change my code setup and figure out another solution so we can meet business deadlines at our side.

FrankTub avatar Apr 04 '24 09:04 FrankTub

Hi @FrankTub I have started working on performance updates to our Netsuite package and will fold your PR into mine. These updates will most likely be released by the end of this month.

In the meantime you should be able to point your packages.yml to the branch that you shared in your PR, since we do not plan to release any updates between now and my next update. Let me know if you have any questions about this!

fivetran-catfritz avatar Apr 05 '24 00:04 fivetran-catfritz

Thanks for the update @fivetran-catfritz , that will work for us.

FrankTub avatar Apr 05 '24 08:04 FrankTub

Have added some additional fields since I want to use the model netsuite2__transaction_details for all sorts of downstream models and need some additional keys to do so that cannot simply be placed in your dbt project as pass through fields.

FrankTub avatar Apr 05 '24 14:04 FrankTub

@FrankTub To update you, I am planning to merge you branch into our next release branch tomorrow. I will also push some small documentation updates to your branch before I do.

fivetran-catfritz avatar Apr 11 '24 22:04 fivetran-catfritz

@FrankTub I have merged your changes into our next release branch to be batch released with our other updates in the coming weeks.

fivetran-catfritz avatar Apr 15 '24 19:04 fivetran-catfritz