dbt_hubspot_source
dbt_hubspot_source copied to clipboard
update/get-ticket-property-history-columns
PR Overview
This PR will address the following Issue/Feature:
- T-746924
-
_fivetran_end
, which should be brought in throughstg_hubspot__ticket_property_history
, is used downstream inint_hubspot__daily_ticket_history
. It only creates an issue if the field is not present, which for most users would never be the case. I only discovered this since I was using theticket_property_history_data
seed from the source, which is different from the seed in the transform, which has this field. - Since
stg_hubspot__ticket_property_history
relies on the macro for the missing fields, adding_fivetran_end
resolves the issue.
This PR will result in the following new package version:
- v0.15.0 since there is the possibility of a new column for users.
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
🚨 Breaking Changes 🚨
- Added field
_fivetran_end
to macroget_ticket_property_history_columns()
to ensure the column available for use downstream.
- While this should not affect most users, this will add a new column
_fivetran_end
tostg_hubspot__ticket_property_history
if you do not have_fivetran_end
in your source TICKET_PROPERTY_HISTORY table.Documentation
- Update documentation to include
_fivetran_end
under modelstg_hubspot__ticket_property_history
.Under the hood
- Updated the maintainer PR template to the current format.
- Included auto-releaser GitHub Actions workflow to automate future releases.
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
- [x] dbt run –full-refresh && dbt test
- [ ] ~dbt run (if incremental models are present) && dbt test~
Before marking this PR as "ready for review" the following have been applied:
- [x] The appropriate issue has been linked, tagged, and properly assigned
- [x] All necessary documentation and version upgrades have been applied
- [x] docs were regenerated (unless this PR does not include any code or yml updates)
- [x] BuildKite integration tests are passing
- [x] Detailed validation steps have been provided below
Detailed Validation
Please share any and all of your validation steps:
- The downstream issue is resolved when adding this.
If you had to summarize this PR in an emoji, which would it be?
:dancer: