dbt_hubspot_source icon indicating copy to clipboard operation
dbt_hubspot_source copied to clipboard

Feature/add union data

Open fivetran-jamie opened this issue 1 year ago • 0 comments

PR Overview

This PR will address the following Issue/Feature: https://github.com/fivetran/dbt_hubspot/issues/130

This PR will result in the following new package version:

v0.15.0

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR: introduces support for running the package on a union of connectors

  • adds union_data macro to each _tmp model
  • includes source relation in each staging model
  • adds yml documentation for source_relation
  • includes source_relation in all uniqueness tests
  • documents unioning ability in README
  • ensures _dbt_source_relation does not slip in when hubspot__pass_through_all_columns is true
  • disables default source if unioning is occurring

dbt_hubspot_source v0.15.0

PR #123 includes the following updates:

🎉 Feature Update 🎉

  • This release supports running the package on multiple Hubspot sources at once! See the README for details on how to leverage this feature.

🛠️ Under the Hood 🛠️

  • Included auto-releaser GitHub Actions workflow to automate future releases.
  • Included Github Actions workflow to check for docs updates.
  • Updated the maintainer PR template to resemble the most up to date format.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • [x] dbt compile
  • [x] dbt run –full-refresh
  • [x] dbt run
  • [x] dbt test
  • [x] dbt run –vars (if applicable) -- ran with diff hubspot__pass_through_all_columns values and specific passthrough columns with add_property_label: true

Before marking this PR as "ready for review" the following have been applied:

  • [x] The appropriate issue has been linked and tagged
  • [x] You are assigned to the corresponding issue and this PR
  • [x] BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

  • [x] You have validated these changes and assure this PR will address the respective Issue/Feature.
  • [x] You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
  • [x] You have provided details below around the validation steps performed to gain confidence in these changes.

See Hex notebook validating transform models

Standard Updates

Please acknowledge that your PR contains the following standard updates:

  • Package versioning has been appropriately indexed in the following locations:
    • [x] indexed within dbt_project.yml
    • [x] indexed within integration_tests/dbt_project.yml
  • [x] CHANGELOG has individual entries for each respective change in this PR
  • [x] README updates have been applied (if applicable)
  • [ ] DECISIONLOG updates have been updated (if applicable)
  • [x] Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

  • [ ] docs were regenerated (unless this PR does not include any code or yml updates) -- will do post-approval

If you had to summarize this PR in an emoji, which would it be?

🇨🇱

fivetran-jamie avatar Jan 08 '24 15:01 fivetran-jamie