dbt_fivetran_log icon indicating copy to clipboard operation
dbt_fivetran_log copied to clipboard

[Feature] Add connector_id to incremental_mar table

Open pkanter opened this issue 2 years ago • 1 comments

Is there an existing feature request for this?

  • [X] I have searched the existing issues

Describe the Feature

It would be handy to have the connector_id in the incremental_mar table, rather than just the connector_name. connector_id was provided in the mar_table_history table.

Describe alternatives you've considered

The alternative is to join on the name, but not a best practice.

Are you interested in contributing this feature?

  • [ ] Yes.
  • [ ] Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • [X] No.

Anything else?

No response

pkanter avatar Feb 17 '23 19:02 pkanter

Hi @pkanter thanks so much for actively engaging with this package and posing this feature request!

I think this is a completely reasonable request. However, the conventional connector_id is not actually included in the raw incremental_mar table. There is a connector_id field; however, after talking with our connector team, this field is in fact the connector_name. You can see us perform this renaming here. If you explore the raw connector_id field in the incremental_mar source you will notice this field is in fact the connector_name equivalent from the connector raw table.

Unfortunately, my team will be unable to add the true connector_id to the package unless it is added to the raw table synced by the connector. In order to recommend that feature request, I would highly encourage opening a feature request via our support portal. From there, you can collaborate with our product team to discuss the feature and why it would be valuable to include in the source (and downstream package staging models).

fivetran-joemarkiewicz avatar Feb 21 '23 15:02 fivetran-joemarkiewicz