dbt_fivetran_log icon indicating copy to clipboard operation
dbt_fivetran_log copied to clipboard

Updating tests to data_tests as of dbt 1.8

Open JustMaris opened this issue 1 year ago • 2 comments

Please provide your name and company Maris, Easypark Link the issue/feature request which this PR is meant to address https://github.com/fivetran/dbt_fivetran_log/issues/133 Detail what changes this PR introduces and how this addresses the issue/feature request linked above. Renamed tests to data_tests How did you validate the changes introduced within this PR? Did a local run. Which warehouse did you use to develop these changes? Snowflake. Did you update the CHANGELOG?

  • [x] Yes

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • [x] Yes

Provide an emoji that best describes your current mood

:dolphin:

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

PR Template

  • Community Pull Request Template (default)

  • Maintainer Pull Request Template (to be used by maintainers)

JustMaris avatar Aug 12 '24 13:08 JustMaris

Have updated changelog and project version. Guide me if I need to do something else or did something not fully correctly.

JustMaris avatar Aug 12 '24 13:08 JustMaris

I bumped lower dbt version to 1.8, as tests don't work with versions below 1.8

JustMaris avatar Aug 12 '24 19:08 JustMaris