ember-cli-migrator icon indicating copy to clipboard operation
ember-cli-migrator copied to clipboard

Migrator stripped window.mixpanel inside mixpanel.js and replaced it just with mixpanel

Open igorT opened this issue 9 years ago • 3 comments

Not really sure how/why but this can lead to very hard to track down errors

igorT avatar Mar 23 '15 11:03 igorT

Hmmm, I thought we had removed the window stripping. And if we left it, I'm not so sure what it is useful for now?

tonysherbondy avatar Mar 23 '15 16:03 tonysherbondy

Looks like it is still there, I may have messed this up in a refactoring... https://github.com/fivetanley/ember-cli-migrator/blob/master/lib/migrator-visitor.js#L69

fivetanley avatar Mar 24 '15 22:03 fivetanley

I've had this with window.location as well

hefox avatar Apr 27 '18 18:04 hefox