lichess-tauri icon indicating copy to clipboard operation
lichess-tauri copied to clipboard

refactor: Migration to tauri v2

Open hashedone opened this issue 11 months ago • 4 comments

Migration to tauri v2 with minimal cleanup. .gitignore files collapsed into single one - some building step likes do remove the whole dist/ and dist/.gitignore happens to get changes to stage. Mostly done by automatical migrations, but some manual alignments had to be done. get_app_data_dir now need to be called on PathResolver - to avoid passing it everywhere, I simply built the path once and stored it as a tauri state (the Db type). Later step could be possibly to maintain the connection to db (however I don't think that makes any difference using sqlite). The PR only seems overwhelming - vast majority of it is Cargo.lock.

hashedone avatar Feb 04 '25 23:02 hashedone

I see the pipeline failing on clippy and test, but it looks like a CI config issue. I take a look what's going on there.

hashedone avatar Feb 04 '25 23:02 hashedone

The only issue failing now is due to some private key issue (looks like key format changed?). The only hint I found is https://github.com/tauri-apps/tauri-action/issues/658#issuecomment-1873477428 (and whats interesting the issue is very recent). I am wondering - is the updater even needed at this point? It is obviously not working - https://fitztrev.github.io/lichess-tauri/version.json is pointing to not existing version. It is also not invoked anywhere, only artifacts are generated. It could be either removed and added from the scratch, or at least keys could be easily regenerated with the new cli for now as obviously noone is using updater feature atm.

hashedone avatar Feb 05 '25 08:02 hashedone

Sounds good, yes you can disable the updater and signing for now

fitztrev avatar Feb 05 '25 14:02 fitztrev

Trying to select an engine binary does nothing, it should open the file picker. I created a PR on hashedone's fork fixing this issue.

FirePlank avatar Nov 12 '25 19:11 FirePlank