bumpalo icon indicating copy to clipboard operation
bumpalo copied to clipboard
verified publisher icon fitzgen

deps: Update criterion to 0.5

Open waywardmonkeys opened this issue 2 years ago • 4 comments

waywardmonkeys avatar Aug 16 '23 16:08 waywardmonkeys

I will get back to you about that (in 18-36 hours as I'm about to disappear for 16 hours or so). There's also the issue of the failed MSRV build. Arguably, the MSRV build shouldn't compile everything, but only the core library?

waywardmonkeys avatar Aug 21 '23 16:08 waywardmonkeys

@fitzgen Okay, I added html_reports to the features for it.

That leaves MSRV. anstyle requires 1.64, you want 1.63 (but the rust-version in the Cargo.toml is still set to 1.60). Would you want to bump to 1.64 or 1.66? Or not compile tests for MSRV?

waywardmonkeys avatar Aug 22 '23 16:08 waywardmonkeys

The tests should run for the MSRV, but benchmarks don't need to. I think cargo compiles all dev deps for tests though.

I think it is fine to bump the MSRV. Would you mind updating the rust-version in Cargo.toml, CI, and the README's documentation as well?

Thanks @waywardmonkeys!

fitzgen avatar Aug 23 '23 16:08 fitzgen

Now anstyle wants 1. 70 or later ... I'm not going to chase this as it is somewhat ridiculous.

waywardmonkeys avatar Dec 12 '23 00:12 waywardmonkeys

Closing old pull requests.

fitzgen avatar Apr 14 '24 19:04 fitzgen