convertdate icon indicating copy to clipboard operation
convertdate copied to clipboard

Add Umm al-Qura calendar support

Open ddohler opened this issue 8 years ago • 5 comments

This is an Islamic calendar used in Saudi Arabia, and it gives dates that are sometimes a day offset from the Islamic calendar calculations in this library. https://github.com/tytkal/python-hijiri-ummalqura

ddohler avatar Jun 10 '16 21:06 ddohler

If that library is working, I'll mark this as "nice to have, not a priority".

fitnr avatar Jun 11 '16 02:06 fitnr

It works as far as I've tested it; it would be nice to have together in one library with other calendars, but the other library should be workable for our use case for now since Umm al-Qura is the only non-Gregorian calendar we need to support at the moment.

In the (probably unlikely) event that we have time for implementation, would you accept a pull request for equivalent functionality here?

ddohler avatar Jun 11 '16 19:06 ddohler

It seems, that this has been merged. Any reason the issue is still open?

feenes avatar May 10 '20 23:05 feenes

@feenes It has not been merged. The item above your comment refers to a different library.

fitnr avatar May 10 '20 23:05 fitnr

I'd like to see this support too, in order to match the [$-1170401] number format of Excel.

snoopyjc avatar Oct 18 '20 04:10 snoopyjc