punchy icon indicating copy to clipboard operation
punchy copied to clipboard

button sounds

Open DRuppFv opened this issue 2 years ago • 1 comments

Note: I removed a lot of code that was not done

Just need help with playing the audio, the audio files are in the PR

DRuppFv avatar Aug 21 '22 21:08 DRuppFv

I believe it is done. I just need someone to test it (my computer is not making sounds) and tell me if the sound is too loud or low.

DRuppFv avatar Sep 01 '22 00:09 DRuppFv

They sound ok to me. I would (personal taste) increase the volume a bit, but it's fine as now.

When I click on "Start Game", I don't hear anything; I don't know if this is intended or not (also on Quit, but that's more likely to be intended).

64kramsystem avatar Sep 02 '22 19:09 64kramsystem

They sound ok to me. I would (personal taste) increase the volume a bit, but it's fine as now.

When I click on "Start Game", I don't hear anything; I don't know if this is intended or not (also on Quit, but that's more likely to be intended).

The quit thing can be easily fixed. Just don't close the game immediately. About the start button, it should just play a different sound, and i don't know the reason. For now, i'll try to fix my computer before updating this PR

DRuppFv avatar Sep 02 '22 19:09 DRuppFv

@64kramsystem I fixed my computer. The "start game" plays the sound! It's just a different one, if you don't like it, i can change.

About the quit game button... To make this work, it would be necessary to OR put audio code in the "exit" button code OR put "exit" button code in the audio code, and i don't think it would be that cool.

DRuppFv avatar Sep 02 '22 20:09 DRuppFv

I fixed my computer. The "start game" plays the sound! It's just a different one, if you don't like it, i can change.

Ah! I've noticed it. I'm neutral to whatever is used, however, it's hard to notice.

64kramsystem avatar Sep 03 '22 11:09 64kramsystem

I fixed my computer. The "start game" plays the sound! It's just a different one, if you don't like it, i can change.

Ah! I've noticed it. I'm neutral to whatever is used, however, it's hard to notice.

It's a "normal" sound of "Start Game" button, you can see something like this in a lot of games like Punchy, but you are right. It would be better if we had a loading screen.

And i just put a new one btw

DRuppFv avatar Sep 03 '22 15:09 DRuppFv

bors merge

odecay avatar Sep 19 '22 03:09 odecay

Build succeeded:

bors[bot] avatar Sep 19 '22 03:09 bors[bot]