bones icon indicating copy to clipboard operation
bones copied to clipboard

feat: update Iroh and enable local network discovery.

Open zicklag opened this issue 1 year ago • 1 comments

This updates to the latest version of iroh-net and enables the local network discovery feature. I can't remember where we left off on LAN but I needed this locally to discover a local matchmaker when I don't have network access to Iroh's pkarr DNS discovery.

Enabling this should completely replace our need for the manual mDNS discovery module for lan networking I think, but I haven't actually done any work on that.

zicklag avatar Sep 08 '24 01:09 zicklag

There is one issue with this, that seems like a bug in Iroh, but the code is as it should work, so I think we can merge it anyway: https://discord.com/channels/1161119546170687619/1282159867423100938/1282159900247720008

The quick summary is that enabling DNS and local swarm discovery is somehow messing up local swarm discovery when DNS isn't available, but again, the code should work as is, so this should be fine.

zicklag avatar Sep 08 '24 02:09 zicklag

Sorry my delays in PRS created some parallel work / merge conflicts heh - I'm going to update jumpy with new matchmaker updates then will resolve some conflicts here + bump to latest iroh and test local discovery

MaxCWhitehead avatar Oct 05 '24 00:10 MaxCWhitehead

Updated packages for cargo deny advisory - but seemed to introduce more issues that I am not sure we can resolve (I'm actually perplexed how the dep tree ends up this way, unless some crates have published crates.io versions that don't match their github versions). Going to revert that and do a minimal update on futures and see where we land...

MaxCWhitehead avatar Oct 08 '24 00:10 MaxCWhitehead

Ok CI failure is just the advisory failure (#479), will test this update in jumpy.

MaxCWhitehead avatar Oct 08 '24 00:10 MaxCWhitehead