bones icon indicating copy to clipboard operation
bones copied to clipboard

remove

Open github-actions[bot] opened this issue 1 year ago • 3 comments

https://github.com/fishfolk/bones/blob/01823b4fe841da4736d92892c103dd65c95025c0/framework_crates/bones_framework/src/networking/online.rs#L375-L382


This issue was generated by todo-issue based on a TODO comment in 01823b4fe841da4736d92892c103dd65c95025c0.

github-actions[bot] avatar Jan 09 '24 16:01 github-actions[bot]

lol @zicklag I need to be more careful about my TODO comments I guess, didn't know they'd open issues. Probably for the best as this way I actually will clean up the comments...

Feel free to assign any of these to me. (At least, the ones that are not real issues)

MaxCWhitehead avatar Jan 16 '24 09:01 MaxCWhitehead

Maybe there's some place in our codebase/docs where we could clearly point out that we've got some special handling in place for TODO comments?

erlend-sh avatar Jan 16 '24 09:01 erlend-sh

Yeah, we have a minor note about TODO comments in the README: https://github.com/fishfolk/bones?tab=readme-ov-file#contributing.

Honestly I probably should have caught this when I reviewed the code to prevent it from getting in in the first place. Either way, it's good that there are obvious so that we must go and remove them, I suppose. :)

zicklag avatar Jan 17 '24 15:01 zicklag

Closing Issue

This comment was generated by todo-issue based on the deletion of a TODO comment in 2f4e7ac48b8c3a6e2617fef5f7e98bf984281943.

github-actions[bot] avatar Oct 02 '24 18:10 github-actions[bot]