friendo-bot icon indicating copy to clipboard operation
friendo-bot copied to clipboard

Published 20 hours ago • verified publisher icon fisher60

Dice command needs default args and better variable naming

Open fisher60 opened this issue 3 years ago • 3 comments

The variable n should be renamed to quantity to match the help description. These should also be passed as default args, probably one six-sided dice as default.

fisher60 avatar Apr 02 '21 20:04 fisher60

Which file are these chnages to be made in..?

Ajay-Singh-Rana avatar Apr 05 '21 08:04 Ajay-Singh-Rana

@Ajay-Singh-Rana Helllo, this issue is pretty much just to clean up this function https://github.com/fisher60/Friendo_Bot/blob/405a25062cd7201d2392c50567b708fa9d14fca0/bot/cogs/fun.py#L162

fisher60 avatar Apr 06 '21 18:04 fisher60

hey i fixed this in a pull request just now. please review and merge thanks

MS-Ignis avatar Apr 11 '21 05:04 MS-Ignis