webtrees icon indicating copy to clipboard operation
webtrees copied to clipboard

Add wrapping behaviour to the fact note.

Open p-litwin opened this issue 1 year ago • 5 comments

Issue: When you add long url to the fact note it overflows the container. I resolved it by adding overflow-wrap: break-word to the .wt-facts-table td .wt-fact-notes p

p-litwin avatar May 20 '24 13:05 p-litwin

We have a CSS class ut (user-generated text) which provides this functionality.

Would it be better to add this class to the p element? This is (possibly) in NoteStructure.php...

fisharebest avatar May 20 '24 13:05 fisharebest

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 33.78%. Comparing base (326ac7e) to head (af8a756).

:exclamation: Current head af8a756 differs from pull request most recent head d986e46

Please upload reports for the commit d986e46 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4987   +/-   ##
=========================================
  Coverage     33.78%   33.78%           
  Complexity    11405    11405           
=========================================
  Files          1177     1177           
  Lines         47514    47514           
=========================================
  Hits          16053    16053           
  Misses        31461    31461           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 20 '24 13:05 codecov[bot]

We have a CSS class ut (user-generated text) which provides this functionality.

Would it be better to add this class to the p element? This is (possibly) in NoteStructure.php...

Good idea For one line inline note it's already there, but multiline note is formatted elsewhere. I didn't locate it yet. I'll check this later.

p-litwin avatar May 20 '24 14:05 p-litwin

I didn't locate it yet. I'll check this later.

I am away for a few days. If you need help finding this, ask me next week.

fisharebest avatar May 23 '24 16:05 fisharebest

I didn't locate it yet. I'll check this later.

I am away for a few days. If you need help finding this, ask me next week.

I found it already. Now it should work fine.

p-litwin avatar May 23 '24 20:05 p-litwin

It seems, there is no change. Can you remove the pull request?

arbor95 avatar Jul 02 '24 10:07 arbor95