webtrees
webtrees copied to clipboard
Improve detection of map provider with missing Api key
fixs https://github.com/fisharebest/webtrees/issues/4758 (now closed)
Applies to map providers that are enabled and require an api key but the key has been omitted.
For users without Admin permissions, previously for the offending provider an exception was raised which blocked access to all the maps. Now the offending provider is silently omitted from the list of available providers and an entry in the error log is made.
For Admin users an exception is raised with a link to the offending providers configuration page. (same as previously)
Codecov Report
Merging #4760 (4f480aa) into main (407d63e) will increase coverage by
0.00%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## main #4760 +/- ##
=========================================
Coverage 30.94% 30.94%
+ Complexity 11357 11354 -3
=========================================
Files 1173 1173
Lines 47873 47865 -8
=========================================
Hits 14812 14812
+ Misses 33061 33053 -8
Impacted Files | Coverage Δ | |
---|---|---|
app/Module/BingMaps.php | 0.00% <ø> (ø) |
|
app/Module/GoogleMaps.php | 0.00% <ø> (ø) |
|
app/Module/HereMaps.php | 0.00% <ø> (ø) |
|
app/Module/MapBox.php | 0.00% <ø> (ø) |
|
app/Module/ModuleMapProviderTrait.php | 0.00% <0.00%> (ø) |
|
app/Services/LeafletJsService.php | 0.00% <0.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.