webtrees
webtrees copied to clipboard
Fix #4700 - "Show all" does not display all individuals in list
Most of my comments about it are already in the bug section.
In the PR, I am giving a slightly different version than in my last comment, but hopefully, it has the same behavior.
It is the first time I have dug into the n_surn
/ n_surname
logic, and I hope I have not missing something fundamentals. Whilst testing, I noted some oddities around the "no surname" case, and case sensitivity, but I feel they go beyond that PR, and I will probably raise further issues to discuss those.
Codecov Report
Merging #4743 (94edd21) into main (8634feb) will increase coverage by
0.00%
. The diff coverage is85.71%
.
@@ Coverage Diff @@
## main #4743 +/- ##
=========================================
Coverage 30.89% 30.90%
- Complexity 11357 11358 +1
=========================================
Files 1188 1188
Lines 47891 47896 +5
=========================================
+ Hits 14796 14800 +4
- Misses 33095 33096 +1
Impacted Files | Coverage Δ | |
---|---|---|
app/Module/IndividualListModule.php | 61.72% <85.71%> (+0.24%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
there has recently (#4904) been a change to this module, so that your patch is no longer valid. Please try actual code and perhaps create a new pull request and close this one!