webtrees icon indicating copy to clipboard operation
webtrees copied to clipboard

Make tables fixed width

Open ddrury opened this issue 2 years ago • 1 comments

For the individual Notes, Media & Sources tabs, make the containing table fixed width (like the facts tab) and used css rather than embedded styles.

Fixes problem with content overflowing the container

ddrury avatar Jun 05 '22 12:06 ddrury

Codecov Report

Merging #4460 (9ebc2b7) into main (87aa77e) will increase coverage by 0.57%. The diff coverage is n/a.

:exclamation: Current head 9ebc2b7 differs from pull request most recent head 7e065e8. Consider uploading reports for the commit 7e065e8 to get more accurate results

@@             Coverage Diff              @@
##               main    #4460      +/-   ##
============================================
+ Coverage     30.93%   31.51%   +0.57%     
+ Complexity    11356    11206     -150     
============================================
  Files          1173     1105      -68     
  Lines         47873    39604    -8269     
============================================
- Hits          14810    12481    -2329     
+ Misses        33063    27123    -5940     

see 885 files with indirect coverage changes

codecov[bot] avatar Jun 05 '22 12:06 codecov[bot]

Fixes problem with content overflowing the container

Which problems?

like the facts tab

I'm not sure why this is fixed.

Taking it out and using the default table-layout seems to make better use of space.

fisharebest avatar Apr 03 '23 22:04 fisharebest

Which problems?

Anything that exceeded the width of the containing element, for example wide census tables The facts and events tab had already fixed this but used inline styling rather than css. I just changes that and copied the code to the other affected tabs.

If you're saying that this problem is now fixed without this bit of code then fine but my gut says it isn't.

ddrury avatar Apr 04 '23 08:04 ddrury