webtrees icon indicating copy to clipboard operation
webtrees copied to clipboard

Pedigree map combined changes

Open ddrury opened this issue 3 years ago • 2 comments

This PR takes the elements applicable to the Pedigree map module from the following PR's so as to provide a consolidated collection of changes. https://github.com/fisharebest/webtrees/pull/4202, https://github.com/fisharebest/webtrees/pull/4203, https://github.com/fisharebest/webtrees/pull/4208, https://github.com/fisharebest/webtrees/pull/4211

ddrury avatar Feb 22 '22 11:02 ddrury

Codecov Report

Merging #4228 (5d4e8b0) into main (415d36f) will decrease coverage by 0.85%. The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #4228      +/-   ##
============================================
- Coverage     32.63%   31.78%   -0.86%     
- Complexity    11047    11072      +25     
============================================
  Files          1093     1090       -3     
  Lines         40449    39047    -1402     
============================================
- Hits          13202    12411     -791     
+ Misses        27247    26636     -611     
Impacted Files Coverage Δ
app/Module/PedigreeMapModule.php 0.00% <0.00%> (ø)
app/Validator.php 58.62% <0.00%> (-37.27%) :arrow_down:
app/Elements/XrefMedia.php 36.84% <0.00%> (-17.01%) :arrow_down:
app/Census/CensusColumnRelationToHead.php 60.00% <0.00%> (-15.00%) :arrow_down:
app/Http/RequestHandlers/AccountEdit.php 81.81% <0.00%> (-11.74%) :arrow_down:
app/Elements/EventTypeCitedFrom.php 90.90% <0.00%> (-9.10%) :arrow_down:
app/Services/TreeService.php 14.28% <0.00%> (-8.90%) :arrow_down:
app/Elements/AbstractEventElement.php 76.92% <0.00%> (-6.42%) :arrow_down:
app/Http/RequestHandlers/UserListData.php 65.30% <0.00%> (-5.39%) :arrow_down:
app/Elements/XrefSource.php 88.88% <0.00%> (-4.87%) :arrow_down:
... and 687 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 415d36f...5d4e8b0. Read the comment docs.

codecov[bot] avatar Feb 22 '22 11:02 codecov[bot]

Note: The following lines should have been removed from chart.phtml in commit "Provide ability to switch the parent-child lines on or off " but were omitted in error and subsequently removed in commit "Add parent identifier & thumbnail image to Pedigree map sidebar".

About lines 113 - 116 in onEachFeature: function (feature, layer) {

if (feature.properties.polyline) {
  let pline = L.polyline(feature.properties.polyline.points, feature.properties.polyline.options);
   markers.addLayer(pline);
}

ddrury avatar Feb 22 '22 14:02 ddrury