webtrees icon indicating copy to clipboard operation
webtrees copied to clipboard

Places module - Avoid zooming to maxZoom level when clicking sidebar entry

Open ddrury opened this issue 3 years ago • 1 comments

Avoid use of markerCluster function zoomToShowLayer but still spiderfy cluster when necessary but set a sensible zoom level first. Uses adaptation of code found on the internet ~~written by the markerCluster author.~~

I'd really like to get rid of the spiderfyDelay timeout but I've tried using map & markercluster events (eg moveend, animationend) and promises (which I'm a novice at) but none work - suggestions welcome.

Update: I've discovered that map.setView doesn't always trigger moveend or zoomend events, however, changing to map.flyTo and catching zoomend event only alllows the timeout to be reduced by half not removed completely.

ddrury avatar Feb 06 '22 20:02 ddrury

Codecov Report

Merging #4208 (0ee08b4) into main (815856a) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4208   +/-   ##
=========================================
  Coverage     31.81%   31.81%           
  Complexity    11084    11084           
=========================================
  Files          1090     1090           
  Lines         39077    39077           
=========================================
  Hits          12431    12431           
  Misses        26646    26646           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 815856a...0ee08b4. Read the comment docs.

codecov[bot] avatar Feb 06 '22 20:02 codecov[bot]